CH-Abhinav commented on PR #16640: URL: https://github.com/apache/lucene/pull/16640#issuecomment-5651791186
I went ahead and implemented off-heap path to `PanamaVectorUtilSupport` for `dotProductBulk` to make end to end connection. while doing so I did following:- 1. Left the base VectorUtilSupport strictly for on-heap arrays 2. Added a public static SIMD batching method directly to `PanamaVectorUtilSupport` to handle off-heap vector unrolling 3. Directed existing `MemorySegmentBulkVectorOps` to new method If everyone is okay with this implementation pipeline then i will go ahead and implement the remaining similarity functions like `cosine` and `squareDistance` . So reviewers out there if you have some time please review this Draft once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
