kaivalnp commented on PR #16678: URL: https://github.com/apache/lucene/pull/16678#issuecomment-5702322303
Thanks @john-mlika, this modification LGTM -- basically pin the `FlatVectorsScorer` to an "expected" implementation instead of inferring from the reader. I'm slightly hesitant to diverge because I'm not sure if that's okay to do, perhaps we could make the same change on `main` and `branch_10x` too? Do you mind opening a follow-up PR to modify the test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
