slow-J commented on PR #16268: URL: https://github.com/apache/lucene/pull/16268#issuecomment-5713650422
> Cool idea and nice improvement! Do we know why BrowseIDOvlpRangeFacets QPS went down? Trying to drill into this, ID tasks (MedTermIDRangeFacets, MedTermIDOvlpRangeFacets, BrowseIDOvlpRangeFacets, BrowseIDRangeFacets) have no skip index in the tested index. Running a new benchmark testing this branch as candidate and this branch less this commit as baseline. I see that lastMod_multi_skipper seems to have a regression while single value looks good. Maybe my testing setup is wrong as its been a few weeks since I ran this last. Will dig into this more. | Task | Field | Pct diff | ±1σ span | p | | --- | --- | ---: | :---: | ---: | | BrowseLastModOvlpRangeFacets | `lastMod_skipper` | +138.0% | [+131%, +145%] | 0.000 | | MedTermLastModOvlpRangeFacets | `lastMod_skipper` | +79.5% | [+72%, +86%] | 0.000 | | BrowseLastModRangeFacets | `lastMod_skipper` | +57.8% | [+52%, +63%] | 0.000 | | MedTermLastModRangeFacets | `lastMod_skipper` | +41.3% | [+30%, +53%] | 0.000 | | MedTermLastModMultiRangeFacets | `lastMod_multi_skipper` | +0.2% | [−9%, +12%] | 0.825 | | MedTermIDRangeFacets | `id` | −0.2% | [−8%, +8%] | 0.821 | | MedTermLastModMultiOvlpRangeFacets | `lastMod_multi_skipper` | −1.1% | [−7%, +5%] | 0.036 | | MedTermIDOvlpRangeFacets | `id` | −2.0% | [−5%, +1%] | 0.000 | | BrowseIDOvlpRangeFacets | `id` | −4.8% | [−6%, −2%] | 0.000 | | BrowseLastModMultiOvlpRangeFacets | `lastMod_multi_skipper` | −5.5% | [−7%, −3%] | 0.000 | | BrowseIDRangeFacets | `id` | −9.2% | [−11%, −6%] | 0.000 | | BrowseLastModMultiRangeFacets | `lastMod_multi_skipper` | −10.1% | [−12%, −7%] | 0.000 | About regression in ID, it is not impacted by this code, so maybe its an issue with JIT? Trying to run some more tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
