rmuir commented on PR #16680: URL: https://github.com/apache/lucene/pull/16680#issuecomment-5714248892
I think `TypeAttribute` is an antipattern for cases like this. You can only set single value for the type and so it is no better than the old Token days. Maybe consider SubwordAttribute which wraps a boolean, or something like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
