kaivalnp commented on PR #16671: URL: https://github.com/apache/lucene/pull/16671#issuecomment-5734918777
As a sanity check that `[Byte|Float]VectorSimilarityQuery.Explicit` is equivalent to the Lucene 10.4 classes, I ran a `luceneutil` KNN benchmark on Cohere v3 vectors, 1024D, 400K docs, 10K queries, force merge to single segment, on Lucene 10.4 v/s 10.5 `branch_10_4` (needed to undo https://github.com/mikemccand/luceneutil/pull/568 locally) ``` resultSimilarity traversalSimilarity resultCount visited recall latency(ms) netCPU avgCpuCount 0.8 0.74 19.071 8020 0.972 2.989 2.988 1.000 0.8 0.76 18.959 2622 0.967 0.942 0.942 0.999 0.8 0.78 18.739 960 0.955 0.352 0.351 0.998 ``` `branch_10_5` (re-use same index, cherry-pick this PR, change `[Byte|Float]VectorSimilarityQuery` -> `[Byte|Float]VectorSimilarityQuery.Explicit`) ``` resultSimilarity traversalSimilarity resultCount visited recall latency(ms) netCPU avgCpuCount 0.8 0.74 19.071 8020 0.972 3.026 3.025 1.000 0.8 0.76 18.959 2622 0.967 1.015 1.014 0.999 0.8 0.78 18.739 960 0.955 0.371 0.371 0.998 ``` I will merge this now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
