jimczi commented on PR #16705: URL: https://github.com/apache/lucene/pull/16705#issuecomment-5814079409
A few more places where prefetch silently does nothing: - `OffHeapFloat16VectorValues` has no prefetch at all, while fp32 and byte do and the layout is the same. So `ScalarQuantizedFloat16VectorValues` now forwards into a no-op and the fp16 rescore stays as it was. - `ExitableDirectoryReader` wraps the three vector values and forwards everything except prefetch, so a search with a timeout loses it with no signal. - Same in `SortingCodecReader`, though that one only matters on the sort/merge path. Maybe worth a test that checks each wrapper forwards, this keeps coming back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
