mayya-sharipova opened a new pull request, #16708: URL: https://github.com/apache/lucene/pull/16708
KnnFloatVectorField, KnnFloat16VectorField and KnnByteVectorField reject non-finite components, and the float and byte fields reject zero vectors with COSINE. The VectorColumn path in IndexingChain only checked doc ids and the dimension, so addBatch accepted vectors that addDocument would reject. Add the equivalent checks to ColumnValidation and apply them for every vector consumed from a VectorColumn, for both dense and sparse columns. KnnFloat16VectorField, added after zero vectors were prohibited for COSINE, never got that check. Add VectorUtil.isZeroVectorFloat16 and reject zero float16 vectors with COSINE in both the field and the column path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
