mayya-sharipova commented on code in PR #16734:
URL: https://github.com/apache/lucene/pull/16734#discussion_r4169802311
##########
lucene/core/src/java/org/apache/lucene/codecs/KnnFieldVectorsWriter.java:
##########
@@ -36,6 +37,28 @@ protected KnnFieldVectorsWriter() {}
*/
public abstract void addValue(int docID, T vectorValue) throws IOException;
+ /**
+ * Add {@code values.size()} vectors for the consecutive doc IDs {@code
[firstDocID, firstDocID +
+ * values.size())}. {@code firstDocID} must be greater than every doc ID
added so far, and every
+ * vector has exactly {@code values.dimension()} elements, which matches the
field's dimension.
+ * Implementations must consume exactly {@code values.size()} vectors.
+ *
+ * <p>The cursor may throw while it is being consumed, for example when a
vector fails validation.
+ * In that case the documents of the whole batch are marked as deleted, but
the writer must remain
Review Comment:
Addressed in e5f1df0c6a7018bffc19c405c2fe2e5f323503a8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
