mikemccand commented on issue #16767: URL: https://github.com/apache/lucene/issues/16767#issuecomment-5996453619
Aha, this is great, thanks @jimczi! I'll try to catch up on those changes. Will `MockDirectoryWrapper` still detect tests that leak open maps? I'm worried now that we open two maps for some codec files (vectors, stored fields, maybe more over time) that we didn't lose `test-framework` coverage that detects not-closed files (e.g. if some path fails to call`finishMerge` in `finally`). And if the user is not using `MMapDirectory`, do we `open` the same file to a new file descriptor? I'll go read the code :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
