kaivalnp commented on code in PR #16764:
URL: https://github.com/apache/lucene/pull/16764#discussion_r4186215711
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsWriter.java:
##########
@@ -642,7 +643,7 @@ static int calculateCentroid(MergeState mergeState,
FieldInfo fieldInfo, float[]
for (int i = 0; i < mergeState.knnVectorsReaders.length; i++) {
KnnVectorsReader knnVectorsReader = mergeState.knnVectorsReaders[i];
if (knnVectorsReader == null) continue;
- count += accumulateCentroid(knnVectorsReader, fieldInfo, centroid);
+ count += accumulateCentroid(knnVectorsReader, fieldInfo,
mergeState.liveDocs[i], centroid);
Review Comment:
Can you update the changelog for the second one too? (i.e. "reduced cases of
preparing unnecessary query data, by making checks consistent b/w flat and HNSW
writers")
Can you also update [this
javadoc](https://github.com/apache/lucene/blob/3970208e0d4d5e997a10baac816bd7d1d7693350/lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorsWriter.java#L82-L84)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
