rmuir opened a new issue, #16776:
URL: https://github.com/apache/lucene/issues/16776

   ### Description
   
   followup to #16744
   
   branch_10x check for the upper bound on java version was increased to java 
27, but the spotless there is older, and doesn't actually work with it. you'll 
get very confusing errors.
   
   I am looking into it and have a prototype, just need to turn it into a PR. 
it is not just bumping the version, but backporting a few logic changes to 
switch back to upstream gjf. I think its worth the trouble to make branch_10x 
easier on everyone.
   
   separately, i'd like to improve the github actions "checks without tests" 
workflow to catch these things. Today it only checks the lower bound (e.g. 21 
for `branch_10x` and 25 for `main`). I think we should add the upper bound of 
the supported range (e.g. 27 for both) to the matrix for this job.
   
   The cost is only a few minutes of CPU time, it won't increase flakiness 
(since it isn't running tests), and it will make it easier for the build to 
check itself. For example evaluating dependabot PRs, JDK bumps, etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to