Pranshu-S commented on code in PR #16710:
URL: https://github.com/apache/lucene/pull/16710#discussion_r4209520295
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/dedup/DedupScalarQuantizedVectorsReader.java:
##########
@@ -427,14 +428,38 @@ private Float16VectorValues
getFloat16VectorValues(FieldEntry entry) throws IOEx
entry.fieldInfo().fieldOrdToGroupOrdBitsPerValue());
}
+ private FieldValues getFloat16QuantizedVectorValues(FieldEntry entry) throws
IOException {
Review Comment:
Not really worth in my opinion, the "FieldValues" technically doesn't take
any vectors which is why we have offset slice as 0 - it is only used for a
bitset iterator to identify which docs have the vectors. I have slightly
tweaked the method to avoid a new function for Float16 and added comment to
make it clear that it is not vector encoding dependent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
