rmuir commented on PR #16789:
URL: https://github.com/apache/lucene/pull/16789#issuecomment-6043196925
> An alternative would be to run it on a weekly basis (scheduled) - much
like we run smoke tester checks these days. Not crucial to fix immediately but
will fail periodically if something incompatible is introduced?
We could do this with something like so:
```diff
--- a/.github/workflows/run-checks-all.yml
+++ b/.github/workflows/run-checks-all.yml
@@ -77,6 +77,13 @@ jobs:
os: [ ubuntu-26.04-arm ]
# run on the lower and upper bound of supported java versions by
the gradle build
java: [ '25', '27' ]
+ trigger:
+ - ${{ github.event_name }}
+ exclude:
+ - java: '27'
+ trigger: push
+ - java: '27'
+ trigger: pull_request
```
It is a bit more complexity, but matches how we handle the tests, and keeps
the locality of reference. The java 27 checks would then run as a scheduled
task at night, similar to how the macos tests run at night. To me, nothing
beats `java: [ '25', '27' ]` for keeping the test matrix easy to understand, so
it is the best alternative I can think of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
