mayya-sharipova commented on PR #16794: URL: https://github.com/apache/lucene/pull/16794#issuecomment-6087553715
@LantaoJin Overall I like the approach, it is safe, very closely follows serial/incremental design. But also there is too many barriers/synchronization 2 * Graphs size. That's why we don't see significant speedups, but I guess 1.31x and 1.17x is also good. Have you experimented with less barriers (e.g. to give each worker its own graph to completely work on), and comparing Recall/QPS graphs with the approach in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
