msokolov commented on PR #16807:
URL: https://github.com/apache/lucene/pull/16807#issuecomment-6127352850
While testing this, I tried removing the Uint8 benchmarking and tested only
the signed 8-bit dot products :+1:
```
+
+ @Benchmark public int combinationScalar() {
+ int ret = 0; ret += binaryDotProductScalar();
+ //ret += binaryDotProductUint8Scalar();
+ ret += binarySquareScalar();
+ //ret += binarySquareUint8Scalar();
+ return ret;
+ }
+
+ @Benchmark @Fork( value = 15, jvmArgsPrepend =
{"--add-modules=jdk.incubator.vector"})
+ public int combinationVector() {
+ int ret = 0;
+ ret += binaryDotProductVector();
+ //ret += binaryDotProductUint8Vector();
+ ret += binarySquareVector();
+ //ret += binarySquareUint8Vector();
+ return ret;
+ }
```
and this shows a disappointing result for the vector version:
```
Benchmark (size) Mode Cnt Score Error
Units
VectorUtilBenchmark.combinationScalar 1024 thrpt 15 1.060 ± 0.001
ops/us
VectorUtilBenchmark.combinationVector 1024 thrpt 75 0.257 ± 0.002
ops/us
```
and this is true with or without the current change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
