hidingmyname opened a new issue, #16828:
URL: https://github.com/apache/lucene/issues/16828

   ### Description
   
   **Location** (lucene @ main f94888d85c1): 
`lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java:46`
   
   **Current text**
   ```
   DocumentWriterPerThread
   ```
   
   **Problem**: The class is `DocumentsWriterPerThread`.
   
   **Suggested fix**: DocumentsWriterPerThread
   
   ```diff
   --- a/lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java
   +++ b/lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java
   @@ -44,5 +44,5 @@
    
    // NOTE: instances of this class are accessed either via a private
   -// instance on DocumentWriterPerThread, or via sync'd code by
   +// instance on DocumentsWriterPerThread, or via sync'd code by
    // DocumentsWriterDeleteQueue
    
   ```
   
   **Already fixed in Lucene.NET**: apache/lucenenet@05c8b5851
   
   **How Lucene.NET fixed it**: commit `05c8b5851fa` (2017-03-30) 
"Lucene.Net.Core.Index (Types starting with A-C): Fixed documentation 
comments", file `src/Lucene.Net.Core/Index/BufferedUpdates.cs`
   
   ```diff
   @@ -27,16 +27,18 @@ namespace Lucene.Net.Index
        using Query = Lucene.Net.Search.Query;
        using RamUsageEstimator = Lucene.Net.Util.RamUsageEstimator;
    
   -    /* Holds buffered deletes and updates, by docID, term or query for a
   -     * single segment. this is used to hold buffered pending
   -     * deletes and updates against the to-be-flushed segment.  Once the
   -     * deletes and updates are pushed (on flush in DocumentsWriter), they
   -     * are converted to a FrozenDeletes instance. */
   -
   -    // NOTE: instances of this class are accessed either via a private
   -    // instance on DocumentWriterPerThread, or via sync'd code by
   -    // DocumentsWriterDeleteQueue
    
   +    /// <summary>
   +    /// Holds buffered deletes and updates, by docID, term or query for a
   +    /// single segment. this is used to hold buffered pending
   +    /// deletes and updates against the to-be-flushed segment.  Once the
   +    /// deletes and updates are pushed (on flush in <see 
cref="DocumentsWriter"/>), they
   +    /// are converted to a FrozenDeletes instance.
   +    /// <para/>
   +    /// NOTE: instances of this class are accessed either via a private
   +    /// instance on <see cref="DocumentsWriterPerThread"/>, or via sync'd 
code by
   +    /// <see cref="DocumentsWriterDeleteQueue"/>
   +    /// </summary>
        public class BufferedUpdates // LUCENENET NOTE: Made public rather than 
internal because it is available through a public API
        {
            /* Rough logic: HashMap has an array[Entry] w/ varying
   ```
   
   I can submit a PR for this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to