gsmiller commented on code in PR #16771: URL: https://github.com/apache/lucene/pull/16771#discussion_r4289411150
########## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsFormat.java: ########## @@ -63,11 +63,13 @@ * that only in sparse case * </ul> * - * <p>NOTE: Arm Neoverse machines have a performance overhead in reading data that is not aligned to - * 64 bytes, so this format aligns the <code>.vec</code> file to that size. There may be a - * performance penalty in searching of float vectors that do <b>not</b> have a dimension of a - * multiple of 16 (equivalent to 64 bytes), because the alignment will not hold for all vectors in - * the file. + * <p>NOTE: this format aligns the vector data of each field in the <code>.vec</code> file to 4096 + * bytes, for every encoding. A vector whose size divides 4096 bytes or is a multiple of it (e.g. + * 1024-dim float32) then never straddles a page boundary, so reading one vector, as rescoring does, Review Comment: I agree with all this @goankur. Thanks for your thoughts! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
