chrisberkhout commented on issue #16861: URL: https://github.com/apache/lucene/issues/16861#issuecomment-6271150457
> This does not make `SegmentCommitInfo` thread-safe or guarantee that a size computed concurrently with mutations is current. In particular, `files()` still reads mutable collections and callers requiring a consistent segment state must retain the appropriate writer-side synchronization. It only restores the intended property that callers never receive the cache sentinel as a size. Yes. Returning the local stops the sentinel being returned. The remaining (existing) issues for callers without the writer-side synchronization are: - The value can be stale or inconsistent (based on a mix of older and newer files) - When recalculating, `files()` can throw an unchecked exception: `ConcurrentModificationException` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
