[
https://issues.apache.org/jira/browse/LUCY-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Wellnhofer updated LUCY-233:
---------------------------------
Attachment: 0105-Autogenerate-an-array-with-initialization-data-for-a.patch
0104-Rework-VTable-method-initialization.patch
0103-Initial-implementation-of-Method-class.patch
0102-Rework-VTable-bootstrapping.patch
0101-Rename-METHOD-macro-to-METHOD_PTR.patch
Here is a reworked patchset (0101-0105) addressing some of your comments. Patch
0105 reworks the VTable initialization even more. I think it's best to first
look at the generated code in autogen/sources/parcel.c to understand the
changes. IMO it makes the whole initialization process more flexible.
Now that VTables are allocated on the heap, I'm not sure if overriding
Inc_RefCount and Dec_RefCount is still needed. I think we could and should use
a normal destructor now. The same for Methods.
> Implement Clownfish Method class
> --------------------------------
>
> Key: LUCY-233
> URL: https://issues.apache.org/jira/browse/LUCY-233
> Project: Lucy
> Issue Type: Task
> Components: Clownfish
> Reporter: Nick Wellnhofer
> Attachments: 0001-Rename-METHOD-macro-to-METHOD_PTR.patch,
> 0002-Rework-VTable-bootstrapping.patch,
> 0003-Initial-implementation-of-Method-class.patch,
> 0004-Rework-VTable-method-initialization.patch,
> 0101-Rename-METHOD-macro-to-METHOD_PTR.patch,
> 0102-Rework-VTable-bootstrapping.patch,
> 0103-Initial-implementation-of-Method-class.patch,
> 0104-Rework-VTable-method-initialization.patch,
> 0105-Autogenerate-an-array-with-initialization-data-for-a.patch
>
>
> As discussed on lucy-dev, it would be nice to have a Clownfish class for
> methods. The VTables would then contain a VArray of Methods which can be used
> to setup host language overrides and later to lookup offsets dynamically.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
