[ 
https://issues.apache.org/jira/browse/LUCY-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495885#comment-13495885
 ] 

Marvin Humphrey commented on LUCY-211:
--------------------------------------

> I've been fighting for hours with random crashes under MSVC6.

Oof, sorry to hear about that.  Final methods can be novel, eh?  Of course
they can. :(

FWIW, that change may have the side effect of seeming to allow host overrides
of final methods.  However, all those behaviors should be rationalized by this
change in the kill_clownfish_host branch:

https://git-wip-us.apache.org/repos/asf?p=lucy.git;a=commitdiff;h=9b29e4bb

{noformat}
-        if ((CFCMethod_public(method) || CFCMethod_abstract(method))
-            && CFCMethod_novel(method)) {
+        if (CFCMethod_novel(method) && !CFCMethod_final(method)) {
{noformat}

I wonder if we want to make it a runtime error to create a subroutine in Perl
with the same name as a final Clownfish method.



                
> MSVC 6 support
> --------------
>
>                 Key: LUCY-211
>                 URL: https://issues.apache.org/jira/browse/LUCY-211
>             Project: Lucy
>          Issue Type: Bug
>            Reporter: Marvin Humphrey
>            Assignee: Nick Wellnhofer
>            Priority: Minor
>         Attachments: LUCY-211-iter1.patch, LUCY-211-iter2.patch
>
>
> MSVC 6 is an old compiler, released in 1998, but some people still use
> it, particularly those motivated by the C runtime linking issue.  It will
> be hard to maintain support without a smoker, but the Lucy mainline 
> should be reasonably close to compatibility right now, so it's worth a 
> try to see if we can build and pass tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to