[
https://issues.apache.org/jira/browse/LUCY-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055766#comment-14055766
]
ASF GitHub Bot commented on LUCY-265:
-------------------------------------
GitHub user timwilkens opened a pull request:
https://github.com/apache/lucy/pull/6
Inline code from `Json_spew_json`.
Change logic to attempt deletion of the PID lockfile regardless of the
outcome of writing to the lockfile.
This fixes LUCY-265.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/timwilkens/lucy master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit 7f8dc100d79c8b0838603e8f1515d9eaf4e60392
Author: Tim Wilkens <[email protected]>
Date: 2014-07-02T01:55:35Z
Inline code from `Json_spew_json`.
Change logic to attempt deletion of the PID lockfile regardless
of the outcome of writing to the lockfile.
----
> Index lockfiles left behind
> ---------------------------
>
> Key: LUCY-265
> URL: https://issues.apache.org/jira/browse/LUCY-265
> Project: Lucy
> Issue Type: Bug
> Components: Store
> Reporter: Tim Wilkens
> Priority: Minor
>
> If the disk on a machine has filled and Lucy attempts to write a lockfile
> using `Json_spew_json` the write will fail and leave the temporary PID
> lockfile behind. This can cause the process which wrote the lockfile or a
> future process with the same PID to be locked out.
> My proposed change will move temporary lockfile creation from
> `Json_spew_json` into `LFLock_Request_IMP` and also attempt to delete the
> lockfile regardless of whether or not the lockfile was written successfully.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
