[
https://issues.apache.org/jira/browse/CLOWNFISH-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369647#comment-14369647
]
ASF GitHub Bot commented on CLOWNFISH-30:
-----------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/5
CLOWNFISH-30 Kill callbacks.h
Refactor CFC internals to eliminate an autogenerated file and centralize
some code generation rather than perform generation per-host.
This fixes CLOWNFISH-30.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-30-kill-callbacks-h
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit c3df5a6ac10a0a7872039cd800772eb30c1be022
Author: Marvin Humphrey <[email protected]>
Date: 2015-03-17T18:03:28Z
Eliminate generation and usage of callbacks.h.
* Declare OVERRIDE symbols in per-class header files.
* Make signatures for invalid OVERRIDES match the original method.
* Generate OVERRIDE symbols centrally rather than for each host.
commit e45af211522b700ae922474c716a8f1f1166fea9
Author: Marvin Humphrey <[email protected]>
Date: 2015-03-19T16:30:50Z
Eliminate vestigial function to write callbacks.h.
----
> Eliminate autogenerated "callbacks.h"
> -------------------------------------
>
> Key: CLOWNFISH-30
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-30
> Project: Apache Lucy-Clownfish
> Issue Type: Improvement
> Components: Compiler
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Priority: Minor
>
> CFC currently expects the autogenerated "callbacks.h" file to be customized
> per-host. This is not really necessary, and we can put the declarations of
> the OVERRIDE symbols into per-class header files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
