[
https://issues.apache.org/jira/browse/LUCY-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526127#comment-14526127
]
ASF GitHub Bot commented on LUCY-277:
-------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy/pull/13
LUCY-277 Adapt for autogenerated Go bindings
Replace some hand-coded proof-of-concept Go bindings with autogenerated Go
glue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy LUCY-277-autogen-go
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 9330b149f936c9431e1c8f4055b4b6366a552d91
Author: Marvin Humphrey <[email protected]>
Date: 2015-05-02T02:16:04Z
Adapt for v4 of Go proof-of-concept bindings.
See CLOWNFISH-28-Go-POC-v4.
* Make structs public: `FooIMP` instead of `implFoo`.
* Embed parent structs.
* Make `ref` a `uintptr` instead of a pointer to a C type.
* Add the INITOBJ method to ObjIMP.
* Eliminate all downstream finalizers and TOPTR() implementations.
commit bab3e4581abb76a806c81b7e35b27a9e023f8be5
Author: Marvin Humphrey <[email protected]>
Date: 2015-04-10T03:18:14Z
Adapt build.go for autogen changes.
commit 66583b24fc823dcb7a479b9d0063b7dd5c4fb8e2
Author: Marvin Humphrey <[email protected]>
Date: 2015-05-02T14:20:51Z
Delete Go glue which is now autogenerated.
Remove handwritten Go glue code which is now replaced entirely by
autogenerated code.
commit 6a96d8f1da4deb3869898faf15e1fa8a8f5622aa
Author: Marvin Humphrey <[email protected]>
Date: 2015-05-03T17:13:36Z
Add LockErr binding which implements `error`.
commit ec9bb9625047de938d67c9850c65bbcd8db5e4a5
Author: Marvin Humphrey <[email protected]>
Date: 2015-05-03T18:13:17Z
Adapt custom Go bindings for autogen.
For classes with Go bindings which use custom struct layouts or spec
custom methods, adapt for new autogenerated CFC interface.
----
> Autogenerate Go Bindings
> ------------------------
>
> Key: LUCY-277
> URL: https://issues.apache.org/jira/browse/LUCY-277
> Project: Lucy
> Issue Type: Improvement
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Fix For: 0.5.0
>
>
> Adapt the proof-of-concept, hand-coded Go bindings from LUCY-275 for
> autogenerated Go bindings enabled by CLOWNFISH-32.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
