[ 
https://issues.apache.org/jira/browse/CLOWNFISH-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563157#comment-14563157
 ] 

ASF GitHub Bot commented on CLOWNFISH-50:
-----------------------------------------

GitHub user nwellnhof opened a pull request:

    https://github.com/apache/lucy-clownfish/pull/23

    CLOWNFISH-50-obj-method-to-inert-v2

    Second version of the pull request that adds type-safe wrappers for 
`get_class`, `get_class_name`, and `is_a` for each class. I chose lowercase 
names like `Str_is_a` because I find them easier to read and write. I'm aware 
that this could result in a name clash if someone decides to implement an inert 
function like `is_a` in a class. But this would be a really bad idea anyway, so 
I don't think it's a problem.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nwellnhof/lucy-clownfish 
CLOWNFISH-50-obj-method-to-inert-v2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy-clownfish/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 303da5fe9392bd41cc87698787ec782116aa0731
Author: Nick Wellnhofer <[email protected]>
Date:   2015-05-27T15:23:59Z

    Make Obj_Get_Class inert

commit b8aa6de6fee1efefafc8f6dcd64f12cb0c795da7
Author: Nick Wellnhofer <[email protected]>
Date:   2015-05-27T15:47:31Z

    Make Obj_Get_Class_Name inert

commit 5bcc19e06c618535371f4cb363dee676cdbd3855
Author: Nick Wellnhofer <[email protected]>
Date:   2015-05-27T16:34:31Z

    Make Obj_Is_A inert

----


> Convert some Obj methods to inert functions
> -------------------------------------------
>
>                 Key: CLOWNFISH-50
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-50
>             Project: Apache Lucy-Clownfish
>          Issue Type: Task
>          Components: Core
>            Reporter: Nick Wellnhofer
>            Assignee: Nick Wellnhofer
>
> Make Obj_Get_Class, Obj_Get_Class_Name, and Obj_Is_A inert.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to