[
https://issues.apache.org/jira/browse/CLOWNFISH-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634095#comment-14634095
]
ASF GitHub Bot commented on CLOWNFISH-32:
-----------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/27
CLOWNFISH-32 Go constructor autogen v2
Autogenerate Go constructor bindings.
The constructors follow Go naming conventions, following the
proof-of-concept bindings: `NewFoo()`
Subtyping is not supported. Under the hood, we use the inert function `new`
when available -- unlike the Perl bindings, which use `init`.
This "v2" pull request differs from the original in that it has been
rebased on top of current master and it omits the ill-considered requirement
that a constructor function be public for the autogenerated binding to trigger.
It also drops the commit making Err's constructor public.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-32-go-ctor-autogen-v2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 024c8154c1cf39c098393eac65b47e21fde75ba2
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-11T23:01:41Z
Add placeholder for generated constructors.
commit d09f15a3ca5547726f0c242d9f5c6a8e73e88b61
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T00:21:14Z
Generalize Go-to-cfish arg list prep.
Make the functionality which converts Go argument lists to
Clownfish-flavored-C argument lists more widely available.
commit 611b0d441cfd8375964ed779ebed137c3b1529d4
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T00:57:29Z
Generalize Go func first line conversion.
Prepare to make the conversion function which generates the first part
of a Go method binding work with constructors and inert functions in
addition to methods.
commit 0728625d2608a4455427241f517631baea5d0d55
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T02:03:41Z
Auto-generate Go bindings for constructors.
commit 021f421e7e82a952af9e3c99698190910ccc3bef
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-14T19:08:58Z
Ensure that converted args outlive call.
Eliminate a race condition by ensuring that the refcount decrement of a
converted argument does not happen until after the call into C
completes.
commit cb1ae674a63267995c67f675a9c1a3dfd16b5008
Author: Marvin Humphrey <[email protected]>
Date: 2015-07-15T21:53:26Z
Add in some missing Go keywords.
----
> Autogenerate Go binding code
> ----------------------------
>
> Key: CLOWNFISH-32
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-32
> Project: Apache Lucy-Clownfish
> Issue Type: Improvement
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
>
> Take the proof-of-concept hand-coded bindings from CLOWNFISH-28 and replace
> them with autogenerated code whenever possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
