[ 
https://issues.apache.org/jira/browse/CLOWNFISH-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649581#comment-14649581
 ] 

ASF GitHub Bot commented on CLOWNFISH-56:
-----------------------------------------

GitHub user rectang opened a pull request:

    https://github.com/apache/lucy-clownfish/pull/28

    CLOWNFISH-56 Go composites

    Perform the following conversions in Go/Clownfish glue code:
    
    *   Blob: `[]byte`
    *   Vector: `[]interface{}`
    *   Hash: `map[string]interface{}`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rectang/lucy-clownfish 
CLOWNFISH-56-go-composites

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucy-clownfish/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit 978a011e36d376319e3afb106995f7ca9822e06a
Author: Marvin Humphrey <[email protected]>
Date:   2015-07-26T00:51:10Z

    Identify convertible core types more robustly.

commit 56e4ab9c21f1b5a9db1cea38ca58cca8539f1a1f
Author: Marvin Humphrey <[email protected]>
Date:   2015-07-28T02:49:59Z

    Wrap any Clownfish object from Go.
    
    Produce a Go func for each Clownfish class, which, given a Clownfish
    C-space object pointer, wraps it in the appropriate Go struct yet
    returns a clownfish.Obj.  Register these funcs in the `clownfish` Go
    package and make them accessible via `clownfish.WRAPAny`.

commit 55d40ac67b7a076050c15e652d51f4a5dfc937a6
Author: Marvin Humphrey <[email protected]>
Date:   2015-07-24T21:23:44Z

    Add GoToClownfish/ToGo conversion routines.

commit 04a573198d2467a87c293833669a00e6f5e2e16b
Author: Marvin Humphrey <[email protected]>
Date:   2015-07-30T23:23:20Z

    Map Vector to Go `[]interface{}`.
    
    Convert Vector to slice of empty interface for both input (func
    parameters) and output (return types).

commit df0244695968125e31b2c2825cfb72ebf0c5951c
Author: Marvin Humphrey <[email protected]>
Date:   2015-07-31T01:10:35Z

    Map Blob to Go `[]byte`.

commit a665132d860925f4de24cd0182a0021a44a6a6ed
Author: Marvin Humphrey <[email protected]>
Date:   2015-07-31T01:20:06Z

    Map Hash to `map[string]interface{}`.

----


> Map Clownfish composite types to Go host types
> ----------------------------------------------
>
>                 Key: CLOWNFISH-56
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-56
>             Project: Apache Lucy-Clownfish
>          Issue Type: Improvement
>          Components: Go
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>             Fix For: 0.5.0
>
>
> Native Clownfish types are cumbersome to deal with from Go.  We already 
> convert clownfish.String to Go strings, both for func parameters and return 
> values.  We should also make the following conversions:
> {noformat}
> * Blob -> []byte
> * Vector -> []interface{}
> * Hash -> map[string]interface{}
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to