[
https://issues.apache.org/jira/browse/CLOWNFISH-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659086#comment-14659086
]
ASF GitHub Bot commented on CLOWNFISH-58:
-----------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/31
CLOWNFISH-58 Hash Store nullable
The signature for Hash's Store() method should accept `nullable` values.
The implementation is already safe for use with NULL values, and we had already
discussed that we needed `Has_Key` to identify keys mapped to NULL.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-58-store-nullable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 11fdf7fecb21102337fe713c35995b7898076143
Author: Marvin Humphrey <[email protected]>
Date: 2015-08-05T01:43:40Z
Hash_Store should accept nullable values.
----
> Refine Hash API
> ---------------
>
> Key: CLOWNFISH-58
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-58
> Project: Apache Lucy-Clownfish
> Issue Type: Improvement
> Components: Core
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Fix For: 0.5.0
>
>
> After reviewing the Hash API ([http://s.apache.org/yzA]), we decided to make
> some refinements:
> * Remove Find_Key.
> * Add Has_Key.
> * Use `size_t` for capacity and other internal variables.
> * Make Hash final.
> * Expose the following methods as public: Clear, Store, Fetch, Delete, Keys,
> Values, Get_Size, Equals
> * Implement Clone() with shallow semantics.
> * CLOWNFISH-2, CLOWNFISH-7, CLOWNFISH-35, CLOWNFISH-36
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
