[
https://issues.apache.org/jira/browse/CLOWNFISH-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939172#comment-14939172
]
ASF GitHub Bot commented on CLOWNFISH-61:
-----------------------------------------
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/39
CLOWNFISH-61 Run core tests under Go
Run the core tests under the Go bindings.
Some kludges are necessary to suppress failures in Err, whose usage of
thread-local storage is not compatible with Go's concurrency model.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish
CLOWNFISH-61-core-tests-under-go
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 1697a39c8167d7ff82c8123bef72d4f457bd6595
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-01T01:44:59Z
Disable thread support under Go.
Err's design relies on thread-local storage, which is not compatible
with Go's goroutines. Resolving the Clownfish and Go concurrency models
is left as a TODO.
commit 276f924e76a7d82420637cb5d5476a7a16283a65
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-01T01:47:02Z
Stub out some TestUtils funcs under Go.
Create stub implementations for some functions that are required for
running the core tests.
commit fe2d3b63c92dc70cb97ed650b613df089005a46c
Author: Marvin Humphrey <[email protected]>
Date: 2015-10-01T01:52:39Z
Run core tests under Go.
----
> Run core tests under Go bindings
> --------------------------------
>
> Key: CLOWNFISH-61
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-61
> Project: Apache Lucy-Clownfish
> Issue Type: Improvement
> Components: Go
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Fix For: 0.5.0
>
>
> The core tests need to be run under the Go bindings, like they are run under
> all hosts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
