[
https://issues.apache.org/jira/browse/CLOWNFISH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203080#comment-15203080
]
ASF GitHub Bot commented on CLOWNFISH-84:
-----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/lucy-clownfish/pull/64
> Guarantee nul-terminated arg to strtod in Str_To_F64
> ----------------------------------------------------
>
> Key: CLOWNFISH-84
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-84
> Project: Apache Lucy-Clownfish
> Issue Type: Bug
> Components: Core
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
>
> As of 0.5.0, Strings consistently lack nul-termination, so usage of `strtod`
> in `Str_To_F64` needs to be adjusted. The solution is to copy the string
> content into a nul-terminated buffer.
> Long term, a more efficient solution would be to craft our own
> string-to-double conversion routine and replace `strtod`, but that's a lot of
> work for little benefit right now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
