[
https://issues.apache.org/jira/browse/LUCY-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marvin Humphrey resolved LUCY-301.
----------------------------------
Resolution: Fixed
> Change Read_C32/etc to explicitly signed Read_CI32/CU32/etc
> -----------------------------------------------------------
>
> Key: LUCY-301
> URL: https://issues.apache.org/jira/browse/LUCY-301
> Project: Lucy
> Issue Type: Sub-task
> Components: C bindings, Core, Go bindings, Perl bindings
> Reporter: Marvin Humphrey
> Assignee: Marvin Humphrey
> Fix For: 0.6.0
>
>
> At present, InStream, OutStream, and NumberUtils provide an unsigned
> compressed format called C32/C64 -- and when we need signed representations,
> we just cast.
> To get rid of all these casts (and fix some sites missing casts), support
> signed and unsigned variants:
> * Write_CI32
> * Read_CI32
> * Write_CU32
> * Read_CU32
> * Write_CI64
> * Read_CI64
> * Write_CU64
> * Read_CU64
> Note that the encoding is not well suited for negative numbers, as they
> always require the maximum of 5 or 10 bytes. However, this change is
> worthwhile simply for the sake of keeping the signs straight in the code
> without casting all the time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
