[
https://issues.apache.org/jira/browse/CLOWNFISH-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404499#comment-15404499
]
ASF GitHub Bot commented on CLOWNFISH-76:
-----------------------------------------
GitHub user nwellnhof opened a pull request:
https://github.com/apache/lucy-clownfish/pull/77
Move some string helpers back to Lucy
Fixes CLOWNFISH-76.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nwellnhof/lucy-clownfish string-helpers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit ca3809d7fb99d8905c83dcbf90221dca2c69bc41
Author: Nick Wellnhofer <[email protected]>
Date: 2016-08-02T16:06:02Z
Disallow invalid code points in CB_Cat_Char
commit 20d282023873c5c7ca1ab87ef5bb84b858f934af
Author: Nick Wellnhofer <[email protected]>
Date: 2016-08-02T16:07:56Z
Remove StrHelp_decode_utf8_char
commit 64a100083d473b498e4fa524360156c47d7008bc
Author: Nick Wellnhofer <[email protected]>
Date: 2016-08-02T16:22:43Z
Stop using UTF8_COUNT array
For most UTF-8 input, especially ASCII text, it's faster to avoid
an additional memory load.
commit ed2010caec0af7ccdcaff76a05cdb516166a6ad4
Author: Nick Wellnhofer <[email protected]>
Date: 2016-08-02T16:46:35Z
Move some functions from StrHelp to Str
- utf8_valid
- validate_utf8
- is_whitespace
- encode_utf8_char
commit 3d3e4cedc5ad224c08614843edda972939baeace
Author: Nick Wellnhofer <[email protected]>
Date: 2016-08-02T17:33:32Z
Move StringHelper from Clownfish to Lucy
----
> Move most string helpers to Lucy
> --------------------------------
>
> Key: CLOWNFISH-76
> URL: https://issues.apache.org/jira/browse/CLOWNFISH-76
> Project: Apache Lucy-Clownfish
> Issue Type: Task
> Reporter: Nick Wellnhofer
> Fix For: 0.6.0
>
>
> Clownfish only needs the following functions from
> Clownfish::Util::StringHelper:
> - StrHelp_utf8_valid
> - StrHelp_encode_utf8_char
> - StrHelp_is_whitespace
> utf8_valid and is_whitespace should be moved to String, encode_utf8_char
> should be made private, and the rest should be moved to Lucy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
