[
https://issues.apache.org/jira/browse/MADLIB-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405609#comment-16405609
]
ASF GitHub Bot commented on MADLIB-1212:
----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/240
> Incorrect step_size update in MLP
> ---------------------------------
>
> Key: MADLIB-1212
> URL: https://issues.apache.org/jira/browse/MADLIB-1212
> Project: Apache MADlib
> Issue Type: Bug
> Components: Module: Neural Networks
> Reporter: Nandish Jayaram
> Priority: Major
> Fix For: v1.14
>
>
> The initialization and update of step_size based on the learning rate policy
> seems to be broken in MLP.
> {code}
> zero_indexed_iteration = current_iteration - 1
> if learning_rate_policy == "exp":
> step_size = step_size_init * gamma**zero_indexed_iteration
> elif learning_rate_policy == "inv":
> step_size = step_size_init * (current_iteration)**(-power)
> elif learning_rate_policy == "step":
> step_size = step_size_init * gamma**(
> math.floor(zero_indexed_iteration / iterations_per_step))
> {code}
> The variable current_iteration in the above code snippet (from
> mlp_igd.py_in) does not seem to be updated in MLP, so the step_size will
> remain the same.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)