[
https://issues.apache.org/jira/browse/MADLIB-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531819#comment-16531819
]
ASF GitHub Bot commented on MADLIB-1175:
----------------------------------------
GitHub user iyerr3 opened a pull request:
https://github.com/apache/madlib/pull/286
Build: Remove symlinks during rpm uninstall
JIRA: MADLIB-1175
`rpm --install` creates three symlinks to `Versions/`, `.../bin`, and
`.../doc`. These symlinks should be deleted during `rpm --erase`.
Additionally, we also delete `Versions/` if it is empty after the erase.
Closes #286
Co-Authored-by: Arvind Sridhar <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib feature/rpm_uninstall_symlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/286.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #286
----
commit cdcd1f6640fe1737fb0ff28393141e4a0cf89d37
Author: Rahul Iyer <riyer@...>
Date: 2018-07-03T19:02:55Z
Build: Remove symlinks during rpm uninstall
JIRA: MADLIB-1175
`rpm --install` creates three symlinks to `Versions/`, `.../bin`, and
`.../doc`. These symlinks should be deleted during `rpm --erase`.
Additionally, we also delete `Versions/` if it is empty after the erase.
Closes #286
Co-Authored-by: Arvind Sridhar <[email protected]>
----
> Uninstall should cleanup symlinks
> ---------------------------------
>
> Key: MADLIB-1175
> URL: https://issues.apache.org/jira/browse/MADLIB-1175
> Project: Apache MADlib
> Issue Type: Improvement
> Components: Build System
> Reporter: Orhan Kislal
> Priority: Major
> Fix For: v1.15
>
>
> Upgrade/install adds a few symlinks to reflect the new folder structure. We
> need an uninstall script that removes these symlinks when madlib is
> uninstalled using the rpm or gppkg. Currently, rpm uninstall will only remove
> the files it explicitly installs (i.e. all madlib files except the symlinks).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
