[
https://issues.apache.org/jira/browse/MADLIB-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594609#comment-16594609
]
ASF GitHub Bot commented on MADLIB-1060:
----------------------------------------
GitHub user hpandeycodeit opened a pull request:
https://github.com/apache/madlib/pull/315
JIRA:1060 - Modified KNN to accept expressions in point_column_name …
JIRA: MADLIB-1060
This PR contains changes for KNN:
1. Modified code - knn.py_in, to support regular PostgreSQL expressions
for point_column_name and test_column_name parameters.
2. Added test cases for the above scenarios.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hpandeycodeit/incubator-madlib MADLIB_1060
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit 6ec93a2becbe32d37e1fd4f01ad59ac70d71dab0
Author: hpandeycodeit <hpandey@...>
Date: 2018-08-28T06:40:13Z
JIRA:1060 - Modified KNN to accept expressions in point_column_name and
test_column_name
----
> Support expressions for column names in k-NN
> --------------------------------------------
>
> Key: MADLIB-1060
> URL: https://issues.apache.org/jira/browse/MADLIB-1060
> Project: Apache MADlib
> Issue Type: Improvement
> Components: k-NN
> Reporter: Frank McQuillan
> Assignee: Himanshu Pandey
> Priority: Minor
> Labels: starter
> Fix For: v2.0
>
>
> Follow on to
> https://issues.apache.org/jira/browse/MADLIB-927
> {code}
> knn( point_source,
> point_column_name,
> label_column_name,
> test_source,
> test_column_name,
> id_column_name,
> output_table,
> operation,
> k
> )
> {code}
> Possible improvements:
> 1) The parameters 'point_column_name' and 'test_column_name' should support
> regular PostgreSQL expressions.
> 2) Should we infer 'c' or 'r' from the data types, rather than have to say
> explicitly?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
