[
https://issues.apache.org/jira/browse/MADLIB-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097381#comment-15097381
]
ASF GitHub Bot commented on MADLIB-954:
---------------------------------------
GitHub user orhankislal opened a pull request:
https://github.com/apache/incubator-madlib/pull/11
Summary: Don't filter columns by name comparison
JIRA: MADLIB-954
- Columns were being filtered by comparing all column names with the
provided target names in Python. This led to issues when names were
not quoted properly. This is now fixed by moving the compare to SQL.
- Output table was being incorrectly dropped.
- Minor PEP8 errors have been fixed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orhankislal/incubator-madlib
bugfix/summary_column_name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/11.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11
----
commit e73065475fcdd417ed43350630d4aabe13d19943
Author: Orhan Kislal <[email protected]>
Date: 2016-01-13T23:10:33Z
Summary: Don't filter columns by name comparison
JIRA: MADLIB-954
- Columns were being filtered by comparing all column names with the
provided target names in Python. This led to issues when names were
not quoted properly. This is now fixed by moving the compare to SQL.
- Output table was being incorrectly dropped.
- Minor PEP8 errors have been fixed.
----
> Check input handling of SUMMARY function
> ----------------------------------------
>
> Key: MADLIB-954
> URL: https://issues.apache.org/jira/browse/MADLIB-954
> Project: Apache MADlib
> Issue Type: Bug
> Reporter: Frank McQuillan
> Fix For: v1.9
>
>
> For the function
> http://doc.madlib.net/latest/group__grp__summary.html
> For a table with the following column:
> depdelay | double precision |
> {code:sql}
> gpuser=> select madlib.summary('faa.otp_r', 'faa.otp_summary1', 'DepDelay');
> {code}
> results in the following error:
> {code}
> ERROR: ZeroDivisionError: float division (plpython.c:4648)
> CONTEXT: Traceback (most recent call last):
> PL/Python function "summary", line 25, in
> get_distinct, get_quartiles, ntile_array, how_many_mfv, get_estimates)
> PL/Python function "summary", line 77, in summary
> PL/Python function "summary", line 382, in run
> PL/Python function "summary"
> {code}
> Don't think this should throw this error.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
