[ 
https://issues.apache.org/jira/browse/MADLIB-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396326#comment-15396326
 ] 

ASF GitHub Bot commented on MADLIB-1001:
----------------------------------------

GitHub user njayaram2 opened a pull request:

    https://github.com/apache/incubator-madlib/pull/58

    Sessionize function: Handling NULL for partition_expr

    JIRA: MADLIB-1001
    
    Changes here now set partition_expr to partition across the whole table
    if it is originally set to NULL or '' by the user. This is in line with
    how path handles partition_expr. Additionally, if output_expr has NULL
    or '' as its value, it is set to '*', which is its default value. Finally,
    the create_view param is also set to its default value True if NULL.
    This commit also contains some formatting changes to the online help.
    
    @iyerr3 @fmcquillan99 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/njayaram2/incubator-madlib 
bugfix/sessionize-feature-comments

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/58.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #58
    
----
commit 17457ea850e0cf8a2cf4100a754c944f7e622c35
Author: Nandish Jayaram <[email protected]>
Date:   2016-07-27T20:27:50Z

    Sessionize function: Handling NULL for partition_expr
    
    JIRA: MADLIB-1001
    
    Changes here now set partition_expr to partition across the whole table
    if it is originally set to NULL or '' by the user. This is in line with
    how path handles partition_expr. Additionally, if output_expr has NULL
    or '' as its value, it is set to '*', which is its default value. Finally,
    the create_view param is also set to its default value True if NULL.
    This commit also contains some formatting changes to the online help.

----


> Sessionization - Phase 2 (output controls)
> ------------------------------------------
>
>                 Key: MADLIB-1001
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1001
>             Project: Apache MADlib
>          Issue Type: New Feature
>          Components: Module: Utilities
>            Reporter: Frank McQuillan
>            Assignee: Nandish Jayaram
>            Priority: Minor
>              Labels: gsoc2016, starter
>             Fix For: v1.9.1
>
>         Attachments: MADlib_ Sessionize_user_doc_v2.pdf
>
>
> Story
> As a data scientist, I want to perform session reconstruction on my data set, 
> so that I can prepare for input into other algorithms like path functions, or 
> predictive analytics algorithms.
> This is a follow on to 
> https://issues.apache.org/jira/browse/MADLIB-909
> to add optional output controls.
> Details 
> Proposed interface changes:
> {code}
> sessionize (
>    source_table,
>    output_table,
>    partition_expr,
>    time_stamp,
>    max_time,
>    output_cols -- new
>    create_view   -- new
>    )
> {code}
> where
> output_cols (optional)
>         TEXT.  
>  asterisk (i.e., '*') -- ALL columns in input table + session column (default)
> 'x, y, z, ...' -- list of columns you want + session column.  This list could 
> include the partition expression or other expressions as desired.  This 
> should also support '*, expr1, expr2, etc.' where this means output all 
> columns + the extra expressions listed.  Needs to a valid SELECT expression.
> For example, in the path function 
> http://madlib.incubator.apache.org/docs/latest/group__grp__path.html#examples
> we do a similar thing for the aggregate function parameter.
> create_view (optional)
>       BOOLEAN default: TRUE. Determines whether to create a view or 
> materialize a table as output. If you only needed session info once, creating 
> a view could be significantly faster than materializing as a table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to