[
https://issues.apache.org/jira/browse/MADLIB-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400091#comment-15400091
]
ASF GitHub Bot commented on MADLIB-1012:
----------------------------------------
GitHub user mktal opened a pull request:
https://github.com/apache/incubator-madlib/pull/60
Path: Proposed fix for JIRA MADLIB-1012
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mktal/incubator-madlib bugfix/path_underscore
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit 54bc0f0a401e8740068ad5717bb72e64adf7ac26
Author: Xiaocheng Tang <[email protected]>
Date: 2016-07-29T22:05:08Z
Path: Proposed fix for JIRA MADLIB-1012
----
> Path - error on symbols defined with underscore "_"
> ---------------------------------------------------
>
> Key: MADLIB-1012
> URL: https://issues.apache.org/jira/browse/MADLIB-1012
> Project: Apache MADlib
> Issue Type: Bug
> Components: Module: Utilities
> Reporter: Frank McQuillan
> Fix For: v1.9.1
>
>
> So when I was looking at
> https://issues.apache.org/jira/browse/MADLIB-995
> I observed that
> {code}
> SELECT madlib.path(
>
> 'eventlog', -- Name of the table
>
> 'path_output', -- Table name to store the path results
>
> 'session_id', -- Partition by session
> 'event_timestamp ASC', -- Order partitions in input table by
> time
> $$ no_buy:=page<>'CHECKOUT',
> buy:=page='CHECKOUT'
> $$, -- Definition of symbols used in the pattern definition
> '(no_buy)+(buy)', -- At least one page followed by and ending
> with a CHECKOUT.
> 'array_agg(page ORDER BY session_id ASC, event_timestamp ASC) as
> page_path',
> FALSE, -- Persist matches
> TRUE -- turn on overlapping patterns
> );
> {code}
> is failing for "no_buy" with this message:
> psql:test-overlapping.sql:31: ERROR: KeyError: '"no_buy"'
> CONTEXT: Traceback (most recent call last):
> PL/Python function "path", line 23, in <module>
> return path.path(**globals())
> PL/Python function "path", line 71, in path
> PL/Python function "path", line 300, in _parse_symbol_str
> PL/Python function "path"
> If I change to "nobuy" it works OK.
> Please check it since
> https://www.postgresql.org/docs/8.2/static/plpgsql-statements.html seems to
> allow "_" for identifiers.
> The wider question is are we supporting standard postgres identifiers for
> symbols? I thought yes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
