[
https://issues.apache.org/jira/browse/MADLIB-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977256#comment-15977256
]
ASF GitHub Bot commented on MADLIB-1076:
----------------------------------------
Github user fmcquillan99 commented on the issue:
https://github.com/apache/incubator-madlib/pull/123
Looks good, thanks for the PR.
One double check: the LICENSE file you are proposing refers explicitly to
libstemmer, useLatex and pyyaml, but does not call out other 3rd party
components by name. Is that your intention?
> Review LICENSE file and README.md
> ---------------------------------
>
> Key: MADLIB-1076
> URL: https://issues.apache.org/jira/browse/MADLIB-1076
> Project: Apache MADlib
> Issue Type: Task
> Components: Documentation
> Reporter: Frank McQuillan
> Assignee: Roman Shaposhnik
> Fix For: v1.11
>
>
> Comments from Ed Espino on 1.10 RC-2 review on thread
> https://mail-archives.apache.org/mod_mbox/incubator-madlib-user/201703.mbox/%3CCAHAuQDzarS7K4u-rOsLLhbwSHCyFn5cKSyjLinE%2BZ%3DjSpU59qw%40mail.gmail.com%3E
> {code}
> LICENSE
> Shouldn't the components with files in licenses/third_party be
> referenced in LICENSE file?
> Boost_Software_License_v1.txt
> Eigen_v3.1.2.txt
> PyXB_v1.2.3.txt
> PyYAML_v3.10.txt
> Python_License_v2.7.1.txt
> UseLATEX_v1.9.4.txt
> _M_widen_init.txt
> argparse_v1.2.1.txt
> From README.md, I only saw an incomplete reference to the third party
> components.
> Third Party Components
> MADlib incorporates material from the following third-party components
>
> argparse 1.2.1 "provides an easy, declarative interface for creating
> command line tools"
> Boost 1.47.0 (or newer) "provides peer-reviewed portable C++ source
> libraries"
> Eigen 3.2.2 "is a C++ template library for linear algebra"
> PyYAML 3.10 "is a YAML parser and emitter for Python"
> PyXB 1.2.4 "is a Python library for XML Schema Bindings"
> {code}
> To dos:
> 1) Confirm that LICENSE file is up to date
> 2) Update README.md with any required 3rd aprty/licensing clarifications
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
