[
https://issues.apache.org/jira/browse/MADLIB-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997139#comment-15997139
]
Frank McQuillan edited comment on MADLIB-1098 at 5/4/17 6:15 PM:
-----------------------------------------------------------------
>From Ed:
Apache Release Audit Tool (RAT):
Observation:
- I happened to open the file "CMakeLists.txt" in the root directory
and noticed it does not have the standard ASF header. I know there
were IP issues resolved globally for the project recently. I
noticed many of them are excluded in the pom.xml file. Regardless
of the IP issues, shouldn't these files contain the ASF header?
Comment from Frank:
CMakeLists.txt
* does not need the standard ASF header since it existed before the move to ASF,
as per ASF legal guidance https://issues.apache.org/jira/browse/LEGAL-293
>From Ed:
======================================================================
Source miscelaneous: HAWQ_Install.txt
Observation:
- The file references the product name as "MADlib" and not "Apache
MADlib (Incubating). Is this file still valid?
Comment from Frank:
The file HAWQ_Install.txt is still valid but could be updated:
https://github.com/apache/incubator-madlib/blob/master/HAWQ_Install.txt
remove this whole paragraph since it is too old:
“Upgrading HAWQ from 1.1 to 1.2
------------------------------
In HAWQ 1.1 a portion of MADlib v0.5 came preinstalled. These functions in their
original form are incompatible with HAWQ 1.2 and will be removed as part of the
HAWQ 1.2 upgrade. Dependencies on MADlib 0.5 should be removed from the
installation before performing the HAWQ 1.2 upgrade. When the HAWQ upgrade is
complete, install MADlib 1.5 or higher and then reinstall the MADlib database
objects using the madpack utility.”
Change first occurrence of MADlib, write as “Apache MADlib (incubating)”
with verbage on what “incubating” means.
was (Author: fmcquillan):
>From Ed:
Apache Release Audit Tool (RAT):
Observation:
- I happened to open the file "CMakeLists.txt" in the root directory
and noticed it does not have the standard ASF header. I know there
were IP issues resolved globally for the project recently. I
noticed many of them are excluded in the pom.xml file. Regardless
of the IP issues, shouldn't these files contain the ASF header?
Comment:
CMakeLists.txt
* does not need the standard ASF header since it existed before the move to ASF,
as per ASF legal guidance https://issues.apache.org/jira/browse/LEGAL-293
>From Ed:
======================================================================
Source miscelaneous: HAWQ_Install.txt
Observation:
- The file references the product name as "MADlib" and not "Apache
MADlib (Incubating). Is this file still valid?
Comment:
The file HAWQ_Install.txt is still valid but could be updated:
https://github.com/apache/incubator-madlib/blob/master/HAWQ_Install.txt
remove this whole paragraph since it is too old:
“Upgrading HAWQ from 1.1 to 1.2
------------------------------
In HAWQ 1.1 a portion of MADlib v0.5 came preinstalled. These functions in their
original form are incompatible with HAWQ 1.2 and will be removed as part of the
HAWQ 1.2 upgrade. Dependencies on MADlib 0.5 should be removed from the
installation before performing the HAWQ 1.2 upgrade. When the HAWQ upgrade is
complete, install MADlib 1.5 or higher and then reinstall the MADlib database
objects using the madpack utility.”
Change first occurrence of MADlib, write as “Apache MADlib (incubating)”
with verbage on what “incubating” means.
> Corrections for MADlib naming consistency
> -----------------------------------------
>
> Key: MADLIB-1098
> URL: https://issues.apache.org/jira/browse/MADLIB-1098
> Project: Apache MADlib
> Issue Type: Improvement
> Reporter: Rashmi Raghu
> Assignee: Rashmi Raghu
> Priority: Minor
> Fix For: v1.11
>
>
> Several locations (e.g. Read Me screen / Intro screen and others) which
> contain the name MADlib should be changed to 'Apache MADlib (Incubating)'.
> Based on observations from the community on dev and user mailing lists (see
> below for excerpts from those discussions).
> ------------------------------------------------
> Copying relevant excerpts from Ed's email:
> http://mail-archives.apache.org/mod_mbox/incubator-madlib-user/201705.mbox/%3CCAHAuQDyn-drvZ64%2B4MYL2A%2BbDdea%3DtTew2boSz8ChdUPH2Aj_Q%40mail.gmail.com%3E
> > ======================================================================
> > Source miscelaneous: HAWQ_Install.txt
> >
> > Observation:
> >
> > - The file references the product name as "MADlib" and not "Apache
> > MADlib (Incubating). Is this file still valid?
> >
> > ======================================================================
> > CONVENIENCE BINARIES
> > ----------------------------------------------------------------------
> >
> > ----------------------------------------------------------------------
> > Mac Installer DMG file: apache-madlib-1.11-incubating-bin-Darwin.dmg
> > ----------------------------------------------------------------------
> >
> > Observation:
> >
> > - The DMG（apache-madlib-1.11-incubating-bin-Darwin.dmg) contains a
> > pkg file named "madlib-1.11-Darwin.pkg". Shouldn't it be called
> > "apache-madlib-1.11-incubating-Darwin.pkg"?
> >
> > Similarly, the DMG base folder name is madlib-1.11.Darwin.
> >
> > Mac Installer Package
> >
> > o Introduction screen
> >
> > Observation:
> >
> > - The introduction screen identifies the product name as
> > "MADlib". Shouldn't there be a mention of the project name being
> > "Apache MADlib (Incubating)".
> >
> > o Read Me screen
> >
> > Observation:
> >
> > - Similar to initial screen, there is no mention to the Apache
> > project except for the link to the project's wiki.
> >
> > o Remaining screens look reasonable (with exception of no Apache
> > references).
> >
> > o The default application window name is "Install MADlib"
> >
> > Observation:
> >
> > - Similar to Introduction sreen, should the name be "Install Apache
> > MADlib (Incubating)"?
> >
> > - Look for other opportunities to reference the product name as
> > "Apache MADlib (Incubating)".
> >
> > ----------------------------------------------------------------------
> > Linux RPM: apache-madlib-1.11-incubating-bin-Linux.rpm
> > ----------------------------------------------------------------------
> >
> > Observation:
> >
> > - It appears the SPEC file used (possibly generated) references the
> > product name as "madlib". Again, shouldn't there be references to
> > the product name as "Apache MADlib" scattered about?
> > Unfortunately, I am not sure if this should change or not. It
> > might help for someone on the team to review other Apache projects
> > convenience binary RPMs to see if something should be
> > addressed. The podling's mentor might be able to provide
> > additional direction as well.
> >
> > This can be seen in the following "rpm -qi madlib" output:
> >
> > [root@e0f4d3349d2d MADlib]# rpm -qi madlib
> > Name : madlib
> > Version : 1.11
> > Release : 1
> > Architecture: x86_64
> > Install Date: Wed May 3 04:00:10 2017
> > Group : Development/Libraries
> > Size : 83575356
> > License : ASL 2.0
> > Signature : (none)
> > Source RPM : madlib-1.11-1.src.rpm
> > Build Date : Tue May 2 19:03:21 2017
> > Build Host : gpdb1.eng.pivotal.io
> > Relocations : /usr/local
> > Vendor : MADlib
> > Summary : Open-Source Library for Scalable in-Database
> > Analytics
> > Description :
> > MADlib is an open-source library for scalable in-database
> > analytics. It
> > provides data-parallel implementations of mathematical,
> > statistical and
> > machine learning methods for structured and unstructured data.
> >
> > The MADlib mission: to foster widespread development of scalable
> > analytic skills, by harnessing efforts from commercial practice,
> > academic research, and open-source development.
> >
> > To more information, please see the MADlib wiki at
> > https://cwiki.apache.org/confluence/display/MADLIB
> >
> > ----------------------------------------------------------------------
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
