ASF GitHub Bot commented on MADLIB-1118:

Github user iyerr3 commented on the issue:

    The change looks good. 
    Few comments: 
    - An alternative to changing the threshold is to reduce the max number of 
iterations. Even with the lower threshold, we're not necessarily guaranteed 
quicker completion. 
    - The log file can be accessed even with the test passing by adding `-vl` 
option to the `madpack install-check` command. The options indicate `-v: 
Verbose` and `-l: Keep logs`. 
    - The install-check itself also provides the run time for execution of the 
whole file. However, `\timing` is needed if run time for individual queries is 
    @njayaram2 Any idea why the asserts on `log_likelihood` are commented out? 

> Reduce size of elastic net install check table
> ----------------------------------------------
>                 Key: MADLIB-1118
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1118
>             Project: Apache MADlib
>          Issue Type: Task
>          Components: Module: Regularized Regression
>            Reporter: Frank McQuillan
>            Assignee: Ed Espino
>            Priority: Minor
>             Fix For: v1.12
> IC is taking too long for elastic net.  I would suggest we reduce the size of 
> the input data table.

This message was sent by Atlassian JIRA

Reply via email to