[
https://issues.apache.org/jira/browse/MAHOUT-2151?focusedWorklogId=844416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844416
]
ASF GitHub Bot logged work on MAHOUT-2151:
------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/23 17:54
Start Date: 08/Feb/23 17:54
Worklog Time Spent: 10m
Work Description: andrewmusselman commented on code in PR #423:
URL: https://github.com/apache/mahout/pull/423#discussion_r1100492640
##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -29,8 +29,18 @@ import org.apache.mahout.math.scalabindings._
import org.apache.mahout.math.scalabindings.RLikeOps._
import MahoutCollections._
+/**
+ * AsFactor is a preprocessor that turns a vector of integers into a vector
of one-hot encoded
Review Comment:
I'd change this to "matrix" instead of "vector of integers"
##########
core/src/main/scala/org/apache/mahout/math/algorithms/preprocessing/AsFactor.scala:
##########
@@ -92,6 +115,12 @@ class AsFactorModel(cardinality: Int, factorVec:
MahoutVector) extends Preproces
res
}
+ /**
+ * Inverse transform the input data - ie transform a one-hot encoded
DrmLike[K] into a
Review Comment:
I don't know what this method does but that comment doesn't look complete..
Issue Time Tracking
-------------------
Worklog Id: (was: 844416)
Time Spent: 20m (was: 10m)
> Add scaladocs for AsFactor
> --------------------------
>
> Key: MAHOUT-2151
> URL: https://issues.apache.org/jira/browse/MAHOUT-2151
> Project: Mahout
> Issue Type: Documentation
> Reporter: Trevor Grant
> Assignee: Trevor Grant
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
