[ http://jira.codehaus.org/browse/MNG-2280?page=comments#action_64854 ] 

Kenney Westerhof commented on MNG-2280:
---------------------------------------

The report plugins already have a tag <plugin><inherited>.

What you're doing here is not really configure inheritance - you're specifying 
wheter modules
(if they have the execution root pom as a parent/ancestor or not) should run a 
report
depending on wheter they're the execution root or not. Inheritance is not a 
plugin <configuration> setting.

Further, why do you want this to be configurable? Some reports that can 
aggregate should decide for themselves
wheter they are aggregating or not. Perhaps an <aggregate> setting is more 
appropriate here? If you were to rename
the <inherit> to <aggregate> we're done.

But since not all reports can aggregate it's a bad thing to define this in the 
abstract base class - any non aggregating
plugin would not execute properly if it isn't the execution root (first project 
in the reactor).

If you want to refactor this, I suggest to add a new AbstractAggregatingPlugin 
with this base functionality.

Thoughts?

> Make inheritance of reports configurable
> ----------------------------------------
>
>          Key: MNG-2280
>          URL: http://jira.codehaus.org/browse/MNG-2280
>      Project: Maven 2
>         Type: Improvement

>     Reporter: Torsten Curdt
>  Attachments: multiproject.diff
>
>
> This makes it possible to configure inheriance of reports.
> <configure>
>   <inherit>false</inherit>
>   ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to