AbstractSiteRenderingMojo causes a NPE if url of current project is not set
---------------------------------------------------------------------------

                 Key: MSITE-176
                 URL: http://jira.codehaus.org/browse/MSITE-176
             Project: Maven 2.x Site Plugin
          Issue Type: Bug
    Affects Versions: 2.0
         Environment: WinXP, Java5
            Reporter: Martin Zeltner
            Priority: Blocker
         Attachments: patch_maven-site-plugin.txt

AbstractSiteRenderingMojo causes a NullPointerException in 
org.apache.maven.doxia.site.decoration.inheritance.DefaultDecorationModelInheritanceAssembler
 if url of current project is not set.

$ mvn site:site
...
[INFO] [site:site]
[INFO] ------------------------------------------------------------------------
[ERROR] FATAL ERROR
[INFO] ------------------------------------------------------------------------
[INFO] null
[INFO] ------------------------------------------------------------------------
[INFO] Trace
java.lang.NullPointerException
        at 
org.apache.maven.doxia.site.decoration.inheritance.DefaultDecorationModelInheritanceAssembler.getParentPrefix
(DefaultDecorationModelInheritanceAssembler.java:340)
        at 
org.apache.maven.doxia.site.decoration.inheritance.DefaultDecorationModelInheritanceAssembler.assembleModelIn
heritance(DefaultDecorationModelInheritanceAssembler.java:46)
        at 
org.apache.maven.plugins.site.AbstractSiteRenderingMojo.getDecorationModel(AbstractSiteRenderingMojo.java:225
)
        at 
org.apache.maven.plugins.site.AbstractSiteRenderingMojo.getDecorationModel(AbstractSiteRenderingMojo.java:217
)
        at 
org.apache.maven.plugins.site.AbstractSiteRenderingMojo.getDecorationModel(AbstractSiteRenderingMojo.java:492
)
        at 
org.apache.maven.plugins.site.AbstractSiteRenderingMojo.createSiteRenderingContext(AbstractSiteRenderingMojo.
java:431)
        at 
org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:108)
        at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:92)
        at 
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:417)
        at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:534)
        at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeStandaloneGoal(DefaultLifecycleExecutor.java:488)
        at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:458)
        at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.jav
a:306)
        at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:273)
        at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:140)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:393)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:182)
        at 
org.apache.maven.embedder.MavenEmbedder.execute(MavenEmbedder.java:690)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:380)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
        at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
        at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
        at org.codehaus.classworlds.Launcher.main(Launcher.java:375)


This url is mostly not set, anyway not for each child module. To solve this 
issue I did the following in method *getDecorationModel* of 
*org.apache.maven.plugins.site.AbstractSiteRenderingMojo*:

If the parent model descriptor exists, the current and the parent model will be 
assembled by using following url parameters:

If parent's url is null but child's not child's url will be used for parent.
If both urls are null the "url" "./" will be used for current and parent.

See appended patch.

Cheers,
Martin




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to