[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594518#comment-14594518
 ] 

Csaba Kozák commented on MCHECKSTYLE-295:
-----------------------------------------

Yes it is. This issue is not about the default value of 
{{includeTestResources}}. Test resources were never checked, because they were 
never passed by the method, and the reference was always {{null}}, as i 
explained in the OP. Also, check out the one-liner patch.

> Test resources are not included
> -------------------------------
>
>                 Key: MCHECKSTYLE-295
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-295
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>          Components: checkstyle:check
>    Affects Versions: 2.15
>            Reporter: Csaba Kozák
>         Attachments: MCHECKSTYLE-295.diff
>
>
> The documentation says the plugin includes test resources by default, but 
> apparently it never does.
> After examining the code, it seems {{CheckstyleViolationCheckMojo.execute()}} 
> forgets to call {{request.setTestResources()}}, hence that is always null and 
> skipped from audit. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to