[
https://issues.apache.org/jira/browse/MSHARED-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hervé Boutemy closed MSHARED-429.
---------------------------------
Resolution: Fixed
Assignee: Hervé Boutemy
Fix Version/s: maven-reporting-impl 2.4
patch applied in [r1687636|http://svn.apache.org/r1687636]
most important fact are there:
- comprehensive unit tests
- general code style
there were still some code style details that I had to fix in
[r1687639|http://svn.apache.org/r1687639], as reported by Checkstyle while
running "msvn install"
Thank you for this great work
> Supposedly invalid URLs are rendered as plain text
> --------------------------------------------------
>
> Key: MSHARED-429
> URL: https://issues.apache.org/jira/browse/MSHARED-429
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl-2.3
> Reporter: Jan Schultze
> Assignee: Hervé Boutemy
> Priority: Minor
> Labels: patch
> Fix For: maven-reporting-impl 2.4
>
> Attachments: local_url_valitdation.patch
>
>
> org.apache.maven.reporting.AbstractMavenReportRenderer#linkPatternedText(String)
> from org.apache.maven.shared::maven-reporting-impl validates URLs before
> rendering. If the validation fails URLs are rendered as plain text. The class
> uses an (in recent versions) deprecated UrlValidator from commons-validator
> which considers unqualified (i.e. local) host names and fully qualified
> domain names with a top level domain longer than 4 characters as invalid
> (such as the special use domain .local or more recent TLDs as .academy and
> .paris). This makes using maven sites in a private network with a .local top
> level domain cumbersome as browsing (proprietary) dependencies site(s)
> requires users to manually copy and paste the URL.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
