[
https://issues.apache.org/jira/browse/MSHADE-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624256#comment-14624256
]
Kai Zheng commented on MSHADE-198:
----------------------------------
Thanks [~elecharny] for the pointing out, it was caused by the packaging. When
changed the packaging to {{jar}}, the issue was resolved.
Silently generating the jar file but ended with {{.pom}} looks strange. To
improve, I thought the Shade plugin could give a hint or warning that reminds
the user in this case the packaging should be {{jar}} instead of {{pom}}.
> In a POM with jar packaging, it generates uber-jar successfully but in a file
> name ended with .pom
> --------------------------------------------------------------------------------------------------
>
> Key: MSHADE-198
> URL: https://issues.apache.org/jira/browse/MSHADE-198
> Project: Maven Shade Plugin
> Issue Type: Improvement
> Reporter: Kai Zheng
>
> In a POM with jar packaging, it generates the uber-jar successfully but in a
> file name ended with .pom. The POM body is as follows.
> {noformat}
> <parent>
> <groupId>org.apache.kerby</groupId>
> <artifactId>kerby-kerb</artifactId>
> <version>1.0-SNAPSHOT</version>
> </parent>
> <artifactId>kerb-client-api-all</artifactId>
> <name>Kerby-kerb client api all</name>
> <description>Kerby-kerb client api all</description>
> <packaging>pom</packaging>
> <dependencies>
> <dependency>
> <groupId>org.apache.kerby</groupId>
> <artifactId>kerb-client</artifactId>
> <version>${project.version}</version>
> </dependency>
> </dependencies>
> <profiles>
> <profile>
> <id>dist</id>
> <build>
> <plugins>
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-shade-plugin</artifactId>
> <version>2.4</version>
> <executions>
> <execution>
> <phase>package</phase>
> <goals>
> <goal>shade</goal>
> </goals>
> <configuration>
> <artifactSet>
> <excludes>
> <exclude>junit:junit</exclude>
> <exclude>org.slf4j:slf4j-api</exclude>
> <exclude>org.apache.kerby:kerby-asn1</exclude>
> </excludes>
> </artifactSet>
> </configuration>
> </execution>
> </executions>
> </plugin>
> </plugins>
> </build>
> </profile>
> </profiles>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
