[
https://issues.apache.org/jira/browse/MNG-5805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633919#comment-14633919
]
Hudson commented on MNG-5805:
-----------------------------
SUCCESS: Integrated in maven-3.x #1093 (See
[https://builds.apache.org/job/maven-3.x/1093/])
MNG-5805: Restore binary compatibility (jason: rev
3677220f6e499e97f2b47b0593bc394b689d14d6)
*
maven-core/src/main/java/org/apache/maven/lifecycle/mapping/LifecyclePhase.java
* maven-core/src/main/java/org/apache/maven/lifecycle/mapping/Lifecycle.java
* maven-core/src/main/java/org/apache/maven/lifecycle/Lifecycle.java
*
maven-core/src/main/java/org/apache/maven/lifecycle/mapping/DefaultLifecycleMapping.java
*
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultLifecyclePluginAnalyzer.java
*
maven-core/src/main/java/org/apache/maven/lifecycle/mapping/LifecycleMapping.java
> Custom packaging types: configuring DefaultLifecycleMapping mojo executions
> ---------------------------------------------------------------------------
>
> Key: MNG-5805
> URL: https://issues.apache.org/jira/browse/MNG-5805
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
> Reporter: Anton Tanasenko
> Assignee: Jason van Zyl
> Priority: Minor
> Fix For: 3.3.4
>
>
> Currently, DefaultLifecycleMapping does not support mapping phases to goals
> with a custom configuration (see
> maven-core/src/main/resources/META-INF/plexus/default-bindings.xml). It is
> impossible to bind, say, an assembly plugin to 'package' phase within a
> custom packaging type, since assembly plugin requires a meaningful
> configuration to be set.
> At my job, we have a number of poms, each serving a purpose of defining a
> lifecycle for a particular type of project (there's one for jar, a couple for
> wars and several more for other types of deployable artifacts).
> Now that I somewhat understand maven's lifecycle, It seems natural to convert
> such poms to custom packaging types, leaving only a single parent with global
> config and pluginManagement. But it is currently impossible, since we are
> using mostly standard plugins (only occasional dedicated ones) to configure
> projects' lifecycles.
> I did some digging around and put together a relatively straightforward
> change to maven-core:
> https://github.com/apache/maven/compare/master...atanasenko:mng-5805-lifecycle-mojo-config?w=1
> It both introduces support for specifying configuration and dependencies for
> mojo executions:
> {code:xml}
> <install>
> <mojos>
> <mojo>
> <goal>org.apache.maven.plugins:maven-install-plugin:2.4:install</goal>
> <configuration>...</configuration>
> <dependencies>...</dependencies>
> </mojo>
> <mojo>
> ...
> </mojo>
> </mojos>
> </install>
> {code}
> as well as retains support for existing mapping syntax:
> {code:xml}
> <install>org.apache.maven.plugins:maven-install-plugin:2.4:install,
> ...</install>
> {code}
> I will put together some its (as well as make sure that existing are running
> ok) and create a pull request for both. Also, there are a couple of changes
> that break API in org/apache/maven/lifecycle/Lifecycle.java and
> org/apache/maven/lifecycle/mapping/Lifecycle.java. How critical is it to
> mantain compatibility in those two?
> ITS:
> https://github.com/apache/maven-integration-testing/compare/master...atanasenko:mng-5805-lifecycle-mojo-config?w=1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
