[
https://issues.apache.org/jira/browse/MNG-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636529#comment-14636529
]
ASF GitHub Bot commented on MNG-5840:
-------------------------------------
GitHub user stephenc opened a pull request:
https://github.com/apache/maven/pull/60
[MNG-5840] Parent version is a range hack
- I don't like this, but it does let all the integration tests pass:
```
Running org.apache.maven.it.MavenITmng2199ParentVersionRangeTest
mng2199ParentVersionRange(ValidParentVersionRangeWithInclusiveUpperBound)OK
(3.7 s)
mng2199ParentVersionRange(ValidParentVersionRangeWithExclusiveUpperBound)OK
(1.7 s)
mng2199ParentVersionRange(InvalidParentVersionRange)........OK (0.7 s)
mng2199ParentVersionRange(ValidParentVersionRangeInvalidVersionExpression)OK
(0.5 s)
mng2199ParentVersionRange(ValidParentVersionRangeInvalidVersionInheritance)OK
(0.4 s)
mng2199ParentVersionRange(ValidLocalParentVersionRange).....OK (0.4 s)
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.509 sec -
in org.apache.maven.it.MavenITmng2199ParentVersionRangeTest
Running org.apache.maven.it.MavenITmng5840ParentVersionRanges
mng5840ParentVersionRanges(ParentRangeRelativePathPointsToWrongVersion)OK
(0.4 s)
mng5840ParentVersionRanges(ParentRangeRelativePathPointsToCorrectVersion)OK
(0.4 s)
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.784 sec -
in org.apache.maven.it.MavenITmng5840ParentVersionRanges
Running org.apache.maven.it.MavenITmng5840RelativePathReactorMatching
mng5840RelativePathReactorMatching(RelativePathPointsToWrongVersion)OK (0.4
s)
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.374 sec -
in org.apache.maven.it.MavenITmng5840RelativePathReactorMatching
```
I have created this as a pull request because I do not like the dependency
change it requires.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stephenc/maven mng-5840-version-range-hack
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/60.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #60
----
commit fc4e341322d708225724363c757012b405cff99e
Author: Stephen Connolly <[email protected]>
Date: 2015-07-22T08:52:01Z
[MNG-5840] Parent version is a range hack
- I don't like this, but it does let all the integration tests pass:
Running org.apache.maven.it.MavenITmng2199ParentVersionRangeTest
mng2199ParentVersionRange(ValidParentVersionRangeWithInclusiveUpperBound)OK
(3.7 s)
mng2199ParentVersionRange(ValidParentVersionRangeWithExclusiveUpperBound)OK
(1.7 s)
mng2199ParentVersionRange(InvalidParentVersionRange)........OK (0.7 s)
mng2199ParentVersionRange(ValidParentVersionRangeInvalidVersionExpression)OK
(0.5 s)
mng2199ParentVersionRange(ValidParentVersionRangeInvalidVersionInheritance)OK
(0.4 s)
mng2199ParentVersionRange(ValidLocalParentVersionRange).....OK (0.4 s)
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.509 sec -
in org.apache.maven.it.MavenITmng2199ParentVersionRangeTest
Running org.apache.maven.it.MavenITmng5840ParentVersionRanges
mng5840ParentVersionRanges(ParentRangeRelativePathPointsToWrongVersion)OK
(0.4 s)
mng5840ParentVersionRanges(ParentRangeRelativePathPointsToCorrectVersion)OK
(0.4 s)
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.784 sec -
in org.apache.maven.it.MavenITmng5840ParentVersionRanges
Running org.apache.maven.it.MavenITmng5840RelativePathReactorMatching
mng5840RelativePathReactorMatching(RelativePathPointsToWrongVersion)OK (0.4
s)
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.374 sec -
in org.apache.maven.it.MavenITmng5840RelativePathReactorMatching
----
> <relativePath> is used if the groupId and artifactId match irrespective of
> the version
> --------------------------------------------------------------------------------------
>
> Key: MNG-5840
> URL: https://issues.apache.org/jira/browse/MNG-5840
> Project: Maven
> Issue Type: Bug
> Affects Versions: 3.3.1, 3.3.3
> Reporter: Stephen Connolly
> Assignee: Stephen Connolly
> Labels: regression
> Fix For: 3.3.5
>
> Attachments: mng-5840-testcase.tar.gz
>
>
> This is a regression. (In my view a serious one)
> Works fine with Maven 3.0 through 3.2.5
> Fails with 3.3.1 and 3.3.3
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
