[
https://issues.apache.org/jira/browse/MSOURCES-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14644984#comment-14644984
]
ASF GitHub Bot commented on MSOURCES-81:
----------------------------------------
GitHub user peterlynch opened a pull request:
https://github.com/apache/maven-plugins/pull/58
MSOURCES-81 add jar maven descriptor if configured
Note: maven-archiver dependency version was upgraded to take advantage of
MavenProject.clone(), which avoids having the new unit test from creating a
maven-archiver directory in the maven-source-plugin basedir because the
MavenProject() constructor used in 2.5 does not copy the build element.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sonatype/maven-plugins
MSOURCES-81-maven-descriptor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-plugins/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
----
> allow sources jar to contain Maven descriptor
> ---------------------------------------------
>
> Key: MSOURCES-81
> URL: https://issues.apache.org/jira/browse/MSOURCES-81
> Project: Maven Source Plugin
> Issue Type: Bug
> Affects Versions: 2.4
> Reporter: Peter lynch
>
> The source:jar mojo explicitly prevents the Maven descriptor from being added
> to the produced -sources.jar file.
> https://github.com/apache/maven-plugins/blob/trunk/maven-source-plugin/src/main/java/org/apache/maven/plugin/source/AbstractSourceJarMojo.java#L292-292
> I could not find an explanation or technical reason why this is done.
> Adding the maven descriptor to the source jar can help expose valuable
> information about the build that produced it.
> Expected:
> - allow the archiver used to create the source jar to respect the plexus
> archiver configuration if it is configured to include the Maven descriptor.
> - preserve the default behaviour of not including the Maven descriptor, for
> (unknown) backwards compatibility reasons only
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
