[
https://issues.apache.org/jira/browse/MNG-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694476#comment-14694476
]
Hervé Boutemy commented on MNG-5871:
------------------------------------
done in [48ae9fd4|http://git-wip-us.apache.org/repos/asf/maven/commit/48ae9fd4]
in a branch for now, since I can't test core ITs at the moment and we're in
release process currently, so this change should wait for next version to have
more time to test
but I'm pretty confident: the new code seems easier to understand, this will
help discussions and permit changes
> make url inheritance algorithm more visible
> -------------------------------------------
>
> Key: MNG-5871
> URL: https://issues.apache.org/jira/browse/MNG-5871
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
> Affects Versions: 3.3.3
> Reporter: Hervé Boutemy
>
> currently, default urls calculated for child from parent values are often
> discussed
> but their implementation is no easy to find: it's a mix between
> - DefaultInheritanceAssembler.getChildPathAdjustment(, which calculates path
> adjustment
> - MavenModelBuilder.appendPath, that calculates the child url: in general,
> parent url is used, but if childpathadjustment is set, this is the algorithm
> to extrapolate child from parent
> IMHO, the test on childpathadjustement is a hack; in fact, we should use
> method overriding: default method just returns arent, but
> DefaultInheritanceAssembler.InheritanceModelMerger should override it with
> the extrapolation algorithm
> this would make the code a lot more clear and help for future enhancements
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
